Skip to content

fix(filter): preserve commas in exclusions - #1343

Merged
Chemaclass merged 2 commits into
mainfrom
fix/1340-literal-cli-exclude-filter
Sep 7, 2026
Merged

fix(filter): preserve commas in exclusions#1343
Chemaclass merged 2 commits into
mainfrom
fix/1340-literal-cli-exclude-filter

Conversation

@Chemaclass

Copy link
Copy Markdown
Member

Background

--exclude-filter 'test_a,{b}' treated the comma in the function name as a list separator. Combined with --filter test_a, it excluded both functions and reported No tests found instead of running test_a.

Changes

  • Keep each repeatable --exclude-filter argument as one literal filter, including commas.
  • Preserve the comma-separated format of BASHUNIT_EXCLUDE_FILTER configuration.
  • Document the distinction and cover the reported Neotest selection scenario end to end.

Validation

  • 83 focused tests and 102 assertions passed.
  • ShellCheck and Bash syntax checks passed.
  • make lint and git diff --check passed.

Checklist

  • I updated the CHANGELOG.md to reflect the fix
  • I updated the documentation to reflect the behavior

Closes #1340

`--exclude-filter` is repeatable, so each argument is one filter. Keep CLI values in an array to avoid colliding with the comma-separated BASHUNIT_EXCLUDE_FILTER configuration.

Closes #1340
@Chemaclass Chemaclass self-assigned this Sep 7, 2026
@Chemaclass Chemaclass added the bug Something isn't working label Sep 7, 2026
@Chemaclass
Chemaclass merged commit 7c1d308 into main Sep 7, 2026
37 checks passed
@Chemaclass
Chemaclass deleted the fix/1340-literal-cli-exclude-filter branch September 7, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comma in a test function name splits --exclude-filter

2 participants