fix(filter): preserve commas in exclusions - #1343
Merged
Merged
Conversation
`--exclude-filter` is repeatable, so each argument is one filter. Keep CLI values in an array to avoid colliding with the comma-separated BASHUNIT_EXCLUDE_FILTER configuration. Closes #1340
JesusValeraDev
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
--exclude-filter 'test_a,{b}'treated the comma in the function name as a list separator. Combined with--filter test_a, it excluded both functions and reportedNo tests foundinstead of runningtest_a.Changes
--exclude-filterargument as one literal filter, including commas.BASHUNIT_EXCLUDE_FILTERconfiguration.Validation
make lintandgit diff --checkpassed.Checklist
CHANGELOG.mdto reflect the fixCloses #1340