fix(coverage): parse case subjects before in - #1342
Merged
Merged
Conversation
An unquoted case subject named `in` was mistaken for the header delimiter. Inside nested substitutions this unbalanced scanner state and could mark skipped commands covered. Align the coverage docs with executable-line and Bash 3.x behavior. Refs #1338
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Follow-up to #1341. In
case in in ..., the coverage scanner treated the firstin, which is the case subject, as the header delimiter. Inside a compact nested case in a substitution, that unbalanced scanner state and could mark a skipped child command as covered.Changes
indelimiter in both Bash and awk scanners.inin a compact nested case.Validation
make lintandgit diff --checkpassed.Checklist
CHANGELOG.mdto reflect the fixRefs #1338