Repository navigation
Run the project's checks in GitHub Actions - #4
Merged
Merged
Conversation
Nothing was running the suites automatically. `.github/workflows/ci.yml` runs them on every pull request and on main, in two parallel jobs: unit tests, types, lint and build in one; the Playwright suite in the other. The end-to-end job needs no credentials, because playwright.config.ts serves the app with TYPESAFE_API_KEY unset and the suite routes through the simulator. Chromium is cached on the lockfile hash, and a failing run uploads its report as an artifact. Node is pinned in the workflow only: the manifest pins neither Node nor a package manager, and this does not change that. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Introduce a committed `.env.1password` file that stores an `op://` reference for `TYPESAFE_API_KEY` (not the secret itself), allow it in `.gitignore`, and add `dev:op`/`start:op` scripts to run Next.js through `op run`. Update README with setup, verification (`/api/route` live status), and precedence details explaining why shell-injected values from `op run` override stale `.env.local` values.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Fix the ineffective Playwright report upload and clarify the scope of the 1Password changes.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds GitHub Actions CI for project checks and Playwright E2E tests, plus optional 1Password-backed development scripts.
Changes:
- Adds parallel unit/type/lint/build and E2E workflow jobs.
- Documents CI coverage and 1Password usage.
- Adds
.env.1passwordreference support.
| File | Summary |
|---|---|
README.md |
Documents 1Password-backed development. |
package.json |
Adds 1Password development scripts; scope should be clarified. |
CONTRIBUTING.md |
Documents CI coverage. |
.gitignore |
Allows the reference environment file. |
.github/workflows/ci.yml |
Defines CI jobs; the Playwright report upload will not find a report with the current reporter configuration. |
.env.1password |
Provides the committed 1Password reference. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+77
to
+82
| - name: Upload report | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: playwright-report | ||
| path: playwright-report/ |
The first run warned that actions/checkout, setup-node and cache at v4 target Node 20, which runners are forcing onto Node 24 ahead of dropping it. Bump to the current majors: checkout and setup-node v7, cache v6, upload-artifact v7. Inputs are unchanged, and this run is the check. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repository had no workflows, so
npm test,npm run typecheck,npm run lint,npm run buildandnpm run e2eonly ever ran on someone's laptop. This adds.github/workflows/ci.yml, which runs them on every pull request and on pushes tomain.Two jobs run in parallel:
npm ci, then the four commands in order.npm ci, Chromium, thennpm run e2e. No credentials:playwright.config.tsbuilds the app and serves it withTYPESAFE_API_KEYunset, so the suite routes through the simulator. A failing run uploads its Playwright report as an artifact.Details worth noting:
package-lock.jsonhash, so the cache rebuilds when Playwright's version moves.concurrencycancels a superseded run on the same branch, andpermissionsiscontents: read.Test plan
npm test(76),npm run e2e(17),npm run typecheck,npm run lint,npm run buildNote for whoever merges: pushing workflow files needs a token with the
workflowscope. The activeghlogin has onlygist, read:org, repo, so this branch was pushed over SSH.🤖 Generated with Claude Code