Repository navigation
Preserve CF-3 focus and approval draft recovery - #495
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Nov 8, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native-question validation and acceptance can drop keyboard focus when the submitting input is disabled or removed. This integrates #489 onto current main and preserves the submitting control after invalid input, moves focus to the answer after acceptance, and respects focus deliberately moved elsewhere.
Approval regressions cover Approve, Deny, Stop and native withdrawal while preserving an independent multiline draft, attachment identity and bytes, reload recovery and focus. Stale answers remain inert.
Validation on signed source candidate
2ef741d00211bfd85e1eadd99ca286786ac5b772: build and workspace typechecks passed; 2,327 unit tests passed with 26 skips; 11 focused Electron cases passed; full E2E passed 502 desktop cases with 7 skips and 7 site cases, without retries. Deliberately corrupting the staged attachment failed the expected byte assertion; the test was restored and hash-verified. Original environment failures are preserved in the receipt.This carries the repair from #489 plus the approval coverage. #276 remains open for human, live-provider and physical-phone acceptance; the existing VoiceOver deferral remains in force. Evidence and remaining owners:
docs/reviews/2026-11-04-cf3-integration.md. Release publication is outside this change.