紀伊細川の英字表記の綴り誤りを修正 - #1627
Merged
Merged
Conversation
station_name_r / station_name_rn がいずれも "Kii-Hosoakwa" となっており、 "Hosokawa" の k と a が入れ替わった綴り誤りだった。カタカナ (キイホソカワ) と住所 (和歌山県伊都郡高野町大字細川) から Hosokawa が正しい。 make ipa-audit で唯一の未解決名として残っていたもので、修正により romaji_to_katakana がそのまま解決し kʲi.i hosokawa を返すようになる。 cargo run -p data_validator は [VALID] No errors reported。 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Px4SXdeBULB87KqD1TzKfy
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
紀伊細川駅(南海高野線)の英字表記が
Kii-Hosoakwaになっていた綴り誤りをKii-Hosokawaに修正する。変更の種類
変更内容
data/3!stations.csvのstation_cd=3200740(紀伊細川)について、station_name_r/station_name_rnをいずれもKii-HosoakwaからKii-Hosokawaに修正。Hosokawaのkとaが入れ替わった綴り誤りで、同レコードのカタカナキイホソカワと住所「和歌山県伊都郡高野町大字細川732」からHosokawaが正しいと判断した。周辺の同線区の駅(Shimokosawa/Kamikosawa/Kii-Kamiya)と同じ表記スタイルに揃う。IPA 生成への影響
make ipa-auditで唯一の未解決名として残っていたもの。修正によりromaji_to_katakana()がそのまま解決するようになり、辞書へ誤った綴りを登録せずに済む。テスト
cargo run -p data_validatorを実行し[VALID] No errors reported.を確認。CSV のみの変更のためコードのチェックは省略。cargo fmt --all -- --checkが通ることcargo clippy -- -D warningsが通ることcargo test(SQLX_OFFLINE=true)が通ること省略: コード変更なし
関連Issue
スクリーンショット(任意)