Repository navigation
Add --plugin to pluginval test and GitHub Actions for validate and acceptance tests - #193
Merged
Merged
Conversation
Both commands can now write machine-readable reports through a shared report_writer. A placeholder error report is written before a run and replaced on completion, and a timeout writes a timed-out report, so a report always agrees with the exit code. A report that can't be written fails the run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #192 (uses
--junit-xml); retarget tov2once that merges.What
pluginval test --plugin <plugin>- overrides the config'splugin, which is now only required when the flag is absent. Lets one set of configs run against whichever binary was just built..github/actions/validate- validates a newline-separated list of plugins (paths, globs or AU ids)..github/actions/acceptance- runspluginval testfor every*.jsonfound recursively under a directory, optionally against one built plugin. Skips the*.wav.jsonreference manifests and fails array configs.v2.0.0-beta1) or usepluginval-path, run every item, write a job-summary table, setpassed/failed/report-diroutputs and fail if anything failed. Shared helpers are in.github/actions/common/common.sh.build.yaml- tags containing a hyphen (e.g.v2.0.0-beta1) are published as pre-releases, so a beta doesn't become "latest"..github/actions/README.md, plus updates to the CI, acceptance, command-line and design docs,CHANGELIST.mdandCLAUDE.md.Testing
--plugin;run-testsand the acceptance CTests pass on macOS.acceptance.ymlnow dogfoods both actions against the in-repo build on Linux, macOS and Windows, including the expected-failure cases (missing plugin, wrong reference, array config, missing reference with and withoutrecord-missing), and asserts the outcomes and counts.Not yet tested
v2.0.0-beta1release to exist (tag it on a commit that includes this PR and Add --junit-xml and --json-results report output to validate and test #192).