Repository navigation
CodeQL: drop alerts in node_modules - #47
Merged
Merged
Conversation
The Java analysis builds the APK, so it also compiles Capacitor's sources from node_modules and reported a java/xss in Capacitor's MessageHandler. paths-ignore has no effect on compiled languages, so the results in node_modules are filtered out of the SARIF before it is uploaded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes code scanning alert #1 (
java/xssin Capacitor'sMessageHandler.java).The Java analysis builds the APK, so it also compiles Capacitor's sources from
node_modulesand reports alerts in library code we can't change.paths-ignorehas no effect on compiled languages, so the workflow now:analyzewithupload: neverand writes the SARIF tosarif-results/node_modules/(jq)upload-sarif(same pinned codeql-action version)Our own Android code in
mobile/androidis still analysed. The alert closes as fixed after the next scan onmain.🤖 Generated with Claude Code