Repository navigation
Skip release creation if it exists - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
tonic-fabricate-jsalready does this: it publishes, then creates the release only if one doesn't exist. This brings the Python client in line with it.Changes
publish-to-pypi.yml. It reads the version frompyproject.tomland usesv<version>as the tag. If a release for that tag exists, it skips. Otherwise it creates one with generated notes and thedist/*.whlanddist/*.tar.gzfiles attached.push: tags: v*trigger, so pushing a tag publishes to PyPI and creates the release. Publishing a release from the UI still works, and the step skips because the release is already there.contents: read, withcontents: writeon the publish job, which creating a release needs.