Skip to content

fix(release): release job 放行 skipped 依赖 #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeliciousBuding merged 1 commit into from
Aug 6, 2026
Merged

fix(release): release job 放行 skipped 依赖 #1647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,9 @@ jobs:
# ── GitHub Release ───────────────────────────
release:
needs: [build-go, build-desktop, build-desktop-macos, build-mobile]
# build-mobile 未启用时（RELEASE_MOBILE_ENABLED != true）会 skipped，
# needs 依赖被跳过会使下游默认跳过；显式放行 skipped、仍拦截 failure。
if: ${{ !cancelled() && !contains(needs.*.result, 'failure') }}
Comment on lines +351 to +353

@coderabbitai coderabbitai Bot Aug 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== workflow outline/relevant lines =="
wc -l .github/workflows/release.yml
sed -n '310,410p' .github/workflows/release.yml

echo
echo "== search for build-mobile / mobile-artifacts / release_mobile_enabled =="
rg -n "build-mobile|mobile-artifacts|RELEASE_MOBILE_ENABLED|download-artifact|upload-artifact" .github/workflows/release.yml

echo
echo "== run yaml parse check if available =="
python3 - <<'PY'
from pathlib import Path
p = Path('.github/workflows/release.yml')
if p.exists():
    text = p.read_text()
    print("file exists and length:", len(text.splitlines()))
else:
    print("missing")
PY

Repository: TokenDanceLab/AgentHub

Length of output: 3817

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== workflow outline/relevant lines =="
wc -l .github/workflows/release.yml
sed -n '310,410p' .github/workflows/release.yml

echo
echo "== search for build-mobile / mobile-artifacts / release_mobile_enabled =="
rg -n "build-mobile|mobile-artifacts|RELEASE_MOBILE_ENABLED|download-artifact|upload-artifact" .github/workflows/release.yml

echo
echo "== run yaml parse check if available =="
python3 - <<'PY'
from pathlib import Path
p = Path('.github/workflows/release.yml')
if p.exists():
    text = p.read_text()
<<<<<<< HEAD
    print("file exists and length:", len(text.splitlines()))
=======
    print("file exists and length:", len(text.splitlines()))
>>>>>>> release
PY

Repository: TokenDanceLab/AgentHub

Length of output: 3865

🌐 Web query:

actions/download-artifact v8 missing artifact error job fails not skipped

💡 Result:

The "Artifact not found" error when using actions/download-artifact@v8 typically indicates that the action cannot locate the specified artifact within the context of the current repository and run ID [1][2]. Because the job fails (instead of skipping), this confirms that the action is actively searching and failing to find the resource, rather than the step being logically skipped [3][4]. To resolve this, ensure the following configurations are met: 1. Verify Version Compatibility: Ensure that you are using actions/upload-artifact@v4 (or newer) to upload the artifact. The v4+ versions of upload/download actions use a different storage mechanism than older versions, and they are not cross-compatible [5][6]. 2. Check Permissions for Cross-Workflow Downloads: If you are downloading an artifact from a different workflow run (e.g., in a workflow_run trigger), the action requires specific permissions. You must add the following to your workflow file [1]: permissions: actions: read contents: read 3. Explicitly Define Inputs for Cross-Workflow Runs: When downloading from a different run, the action often requires explicit definition of the github-token, repository, and run-id, even if they match the defaults [1][2]. - name: Download Artifact uses: actions/download-artifact@v8 with: name: your-artifact-name github-token: ${{ github.token }} run-id: ${{ github.event.workflow_run.id }} repository: ${{ github.repository }} 4. Artifact Availability: Ensure the artifact has not expired [3][7]. Additionally, some users have noted that artifacts may not be immediately available if a job is part of a large matrix or if the upload step has not fully completed/flushed to the storage backend before the download step begins [8]. If the job fails without a clear error message (sometimes seen on Windows runners), it may be due to underlying Node.js crashes rather than a configuration error [4]. In such cases, check the debug logs (by setting ACTIONS_STEP_DEBUG=true in your secrets) to identify potential stack buffer overflows or environment-specific failures [4].

Citations:

为可选移动端构建条件化 artifact 下载。

当 RELEASE_MOBILE_ENABLED != 'true' 时，build-mobile 不会上传 mobile-artifacts；release 仍会执行，继续下载该 artifact 会失败。请在下载步骤添加 if: ${{ needs.build-mobile.result == 'success' }}，或让条件不允许跳过 build-mobile 时进入 release。

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/release.yml around lines 351 - 353, Condition the mobile
artifact download step on build-mobile completing successfully by adding an if
expression using needs.build-mobile.result == 'success'. Keep the release job’s
existing failure and cancellation gating unchanged, while ensuring skipped
build-mobile does not attempt the download.

Source: MCP tools

runs-on: ubuntu-latest
permissions:
contents: write
Expand Down
Loading