fix(desktop): macOS keyring 使用 keychain::Store 模块路径 - #1644
Merged
Conversation
apple-native-keyring-store 1.0.0 的 keychain feature 导出 keychain 模块 而非顶层 Store;secure_store.rs 引用顶层 Store 导致 E0433。Windows 构建 不受影响(rc.1 已验证),此修复仅影响 macOS DMG 构建。
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe macOS credential store initialization now uses ChangesCredential store initialization
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apple-native-keyring-store1.0.0 的keychainfeature 导出keychain模块而非顶层Store,secure_store.rs 引用顶层 Store 导致 E0433,阻断 macOS DMG 构建apple_native_keyring_store::keychain::Store::new()(与 windows 分支的Result<Arc<Self>>签名一致)Test plan
cargo check通过(Windows)Summary by CodeRabbit