Skip to content

fix(desktop): macOS keyring 使用 keychain::Store 模块路径 - #1644

Merged
DeliciousBuding merged 1 commit into
masterfrom
fix/desktop-macos-keychain-store
Aug 6, 2026
Merged

fix(desktop): macOS keyring 使用 keychain::Store 模块路径#1644
DeliciousBuding merged 1 commit into
masterfrom
fix/desktop-macos-keychain-store

Conversation

@DeliciousBuding

@DeliciousBuding DeliciousBuding commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • apple-native-keyring-store 1.0.0 的 keychain feature 导出 keychain 模块而非顶层 Store,secure_store.rs 引用顶层 Store 导致 E0433,阻断 macOS DMG 构建
  • 修复:apple_native_keyring_store::keychain::Store::new()(与 windows 分支的 Result<Arc<Self>> 签名一致)

Test plan

  • 本地 cargo check 通过(Windows)
  • API 签名与 crate 源码核对(keychain.rs:161 Store / 178 new / 212 CredentialStoreApi)
  • CI 全绿
  • rc 重跑时 build-desktop-macos 通过

Summary by CodeRabbit

  • Bug Fixes
    • Improved credential store initialization on macOS for more reliable secure credential access.

apple-native-keyring-store 1.0.0 的 keychain feature 导出 keychain 模块
而非顶层 Store;secure_store.rs 引用顶层 Store 导致 E0433。Windows 构建
不受影响(rc.1 已验证),此修复仅影响 macOS DMG 构建。
Copilot AI lite review requested due to automatic review settings August 6, 2026 05:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2a864163-1378-4331-a4c1-e31cd164731c

📥 Commits

Reviewing files that changed from the base of the PR and between 1c63be0 and d6495cb.

📒 Files selected for processing (1)
  • app/desktop/src-tauri/src/secure_store.rs

📝 Walkthrough

Walkthrough

The macOS credential store initialization now uses apple_native_keyring_store::keychain::Store. Windows and Linux initialization remain unchanged.

Changes

Credential store initialization

Layer / File(s) Summary
Use the keychain Store constructor
app/desktop/src-tauri/src/secure_store.rs
The macOS constructor changed to apple_native_keyring_store::keychain::Store::new().

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the desktop macOS keyring module path fix, which matches the main change.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/desktop-macos-keychain-store

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DeliciousBuding
DeliciousBuding merged commit 2505380 into master Aug 6, 2026
22 checks passed
@DeliciousBuding
DeliciousBuding deleted the fix/desktop-macos-keychain-store branch August 6, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants