Skip to content

fix(desktop): 恢复 macOS keychain feature 修复 DMG 构建 - #1643

Merged
DeliciousBuding merged 1 commit into
masterfrom
fix/desktop-macos-keyring
Aug 6, 2026
Merged

fix(desktop): 恢复 macOS keychain feature 修复 DMG 构建#1643
DeliciousBuding merged 1 commit into
masterfrom
fix/desktop-macos-keyring

Conversation

@DeliciousBuding

Copy link
Copy Markdown
Collaborator

Summary

  • commit 51bb1b97 移除 keyring v4 时丢失了平台 store 的 feature 声明,apple-native-keyring-store 在 macOS 上必须启用 keychainprotected feature,否则 compile_error 阻断 DMG 构建
  • 修复:macOS target 依赖启用 features = ["keychain"],Cargo.lock 引入 security-framework
  • windows/linux store 无 feature 要求,无需改动

Test plan

  • 本地 cargo check 通过(Windows)
  • CI: validate + go-hub lint + build-desktop(Windows)
  • rc 重跑时 build-desktop-macos 通过

commit 51bb1b9 移除 keyring v4 依赖时丢失了平台 store 的 feature 声明:
apple-native-keyring-store 在 macOS 上必须启用 keychain 或 protected
feature,否则编译失败(compile_error 阻断),导致 release 的
build-desktop-macos job 失败。windows/linux store 无 feature 要求。

Cargo.lock 相应引入 security-framework。
Copilot AI lite review requested due to automatic review settings August 6, 2026 05:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@DeliciousBuding, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 seconds

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2aff6ea4-b0e8-4589-a534-85c7e266f2b8

📥 Commits

Reviewing files that changed from the base of the PR and between 8227c1a and 2d929c4.

⛔ Files ignored due to path filters (1)
  • app/desktop/src-tauri/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • app/desktop/src-tauri/Cargo.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DeliciousBuding
DeliciousBuding merged commit 1c63be0 into master Aug 6, 2026
26 checks passed
@DeliciousBuding
DeliciousBuding deleted the fix/desktop-macos-keyring branch August 6, 2026 05:34
DeliciousBuding added a commit that referenced this pull request Aug 7, 2026
* chore(docs): v0.6.0 发布收尾 — CHANGELOG 补发布修复、MASTER 记 DONE

neat-freak 收尾:
- CHANGELOG v0.6.0 条目补 macOS 发布链路与 release job 6 项修复(#1643-#1648)
- MASTER Active 表新增 v0.6.0 正式发布 DONE 行(rc.1-rc.4 tag 已清理,rc.5 保留)
- MASTER Last updated 刷新至 2026-08-07

* fix(deps): pnpm audit 全清 — js-yaml 4.3.1 / mermaid 11.16.1 overrides

npm 新公告(2026-08-07 起 CI pnpm audit 失败):
- mermaid <11.16.1 5 项(@lobehub/ui 间接依赖:CSS 注入/原型污染/XY 图无限循环等)
- js-yaml@4 <4.3.1 1 项 high(CVE-2026-59870,expo CLI 链)
overrides 下限提高并本地验证 audit 0 漏洞。

---------

Co-authored-by: Codex (Delicious233) <codex@vectorcontrol.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants