Repository navigation
Conversation
…carce macOS runners The release rebuilt the macOS app from scratch every time: reuse-binaries.sh looked for a tinyclient.app folder, but upload-artifact keeps only what is inside the folder it is given, so the download is Contents/ alone. v0.2.66's macOS job spent 13 of its 14 minutes compiling what CI had already built. It now looks for Contents/MacOS, as Windows and Linux already reuse. The org gets two macOS runners at a time, shared by CI's tests and package, the iOS build and the release; v0.2.66's iOS build waited 24 minutes for one. A pull request now tests on Linux and Windows only, and main adds macOS. The window's tests, which build only with the gui feature, run on Linux for a pull request so they are not lost with the Mac. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Shipping v0.2.66 took 33 minutes from tag to published, and two thirds of that went to macOS. Release rebuilt the Mac app it was supposed to reuse from CI, and the iOS build waited 24 minutes for a macOS runner, because the org gets only two at a time. This PR fixes the first and stops pull requests from taking macOS runners for tests.
reuse-binaries.shlooked for atinyclient.appfolder. CI uploadstarget/release/tinyclient.app, and upload-artifact keeps only what's inside it, so the download isContents/with no folder around it. The lookup never matched, and every release compiled macOS again: 13 of the macOS job's 14 minutes in v0.2.66. It now findsContents/MacOS. Windows and both Linux jobs already reused CI's builds and took about 1 minute each.guifeature, which only the Mac job turned on. On a PR, the Linux job turns it on instead, so those tests still run before merge.Type
Platforms
Proof
CI change, no app behaviour.
reuse-binaries.shagainst the realtinyclient-macosartifact from v0.2.66's CI run (43071835317). The old script found nothing in it. The new one copies all four Mach-O programs. Locally it still reportedfound=false, but only on the executable-bit check, because Windows has no executable bits. On a macOS runner the script'schmod +xsets them.test (macos-latest), andtest (ubuntu-22.04)running with theguifeature.using tinyclient-macos from CI run …and take about 2 minutes.Compatibility
CI only. No required status check names
test (macos-latest).Risk and rollback
Release note
None (CI only).
🤖 Generated with Claude Code