Repository navigation
docs: keep the ledger in place when restoring the node DB - #500
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details: TC-887
Adds the restore-order rule, in bold, to docs/encryption-named-keys.md "Deletion ledger": when the node DB is restored from a PlanetScale backup, keep the node's existing disk and its deletion ledger, then boot normally. The boot replay then re-shreds keys deleted after the backup. Restoring onto a fresh disk without the ledger undoes those later deletions.
This assumes there is no off-disk ledger backup; that is the risk Sam accepted. The backup sidecar is draft #499, on hold. Docs only, no code or config change.