Repository navigation
Conversation
Details: TC-2219
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
combineinputs to at most twice the validated current member count. Duplicates count toward the limit.CombineError::TooManyShareswithout a member before request/share bindings, supplied-entry processing or algebra when the input exceeds the limit.Base:
00643ae8b445e019b45a03923caf65400102825dHead:
bb6133098d247bd2c3fb67e3cfd3de6faee8096bVerification
Executed on the final Rust source before the documentation-only additions:
cargo test --locked -p tinycloud-threshold p3_ -- --nocapturerun produced 3 passes and 2 behavior failures: over-limit acceptance and count-check precedence. The identity-c3 regression already passed before the guard.cargo test --locked -p tinycloud-threshold— 50 passed, 0 failed, 0 ignored; 0 doc-tests. Includes the existing primitive byte-for-byte comparison.cargo clippy --locked -p tinycloud-threshold --all-targets -- -D warnings— exit 0.cargo fmt --check -p tinycloud-threshold— exit 0.All local Cargo work used isolated homes/target and two build jobs. Both granted slots were released immediately. The existing threshold lane in
.github/workflows/rust.ymlruns the full crate suite, including these inline tests; no CI configuration change is needed.Dependency licences (unchanged)
The crate retains the workspace TinyCloud EGPL v1.5 licence file,
publish = false, existing release configuration and unwired workspace membership.PROVENANCE
derive.rs,error.rsand deterministiccheckpoint.rsfixture/dealer: existing API conventions, valid responses and regression construction.test-ruling: TC-2219
The boundary and canonical identity-c3 regression additions are authorized by the owner disposition in TC-2219 comment
ab185d99-1b8f-4cab-83a2-e235e0994ba1and the scoped implementation instruction. Existing test assertions and fixtures are unchanged.Details: TC-2219