Conversation
Both files exist under source/ but appear in neither _FILES nor _BINS in cmake/CMakeLists.txt, so they never compile: mdsave.f fails on the missing uatom module and the link fails with undefined references to uniquetyp_/velunique_. Adding both names to the alphabetical list restores the build. Fixes TinkerTools#184.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building from
mainfails partway through:mdsave.fcannot open theuatommodule, and the link then stops with undefined references to symbols from the two files below (utv1/utv2/utv3,uniquetyp_,velunique_). The build compiles a hand-maintained source list —set(_FILES ...)incmake/CMakeLists.txt— anduatom.fanduniquetyp.fare the only files undersource/that appear in neither_FILESnor_BINS, so neither is ever compiled:mdsave.fuses theuatommodule and callsvelunique, andmdinit.fcallsuniquetyp. Adding both names to the list in their alphabetical positions fixes the compile and link stages with no other change. Verified on Linux with gfortran 13.3; the resulting binaries reproduce the release binaries' output on the same inputs. Fixes #184.