Skip to content

Streamline the proxy reduce tactic #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frankmcsherry wants to merge 2 commits into from
Closed

Streamline the proxy reduce tactic #827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21a7a9e
Streamline the proxy reduce tactic
frankmcsherry Aug 12, 2026
a46c90d
Reorganize
frankmcsherry Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions differential-dataflow/src/operators/int_proxy/history.rs
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion differential-dataflow/src/operators/int_proxy/join.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
use crate::operators::join::{Fresh, JoinTactic};
use crate::operators::ValueHistory;

use super::history::IdHistory;
/// A value history suitable for integer proxy values.
type IdHistory<T, R> = ValueHistory<u64, T, R>;

/// A type that can interpret and retire pairs of lists of batches, joined by key hashes.
///
Expand Down Expand Up @@ -238,7 +239,7 @@
/// If either history is small, this performs a direct cross product.
/// If both histories are large, this replays the histories compacting as it goes in
/// order to (potentially) avoid quadratic blow-up.
fn join_key<T, R0, R1, RO>(

Check warning on line 242 in differential-dataflow/src/operators/int_proxy/join.rs

View workflow job for this annotation

GitHub Actions / Cargo clippy 

this function has too many arguments (8/7)
kh: u64,
p0: &ProxyBridge<T, R0>,
r0: std::ops::Range<usize>,
Expand Down
1 change: 0 additions & 1 deletion differential-dataflow/src/operators/int_proxy/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
//! Both are welcome to efficiently notice that there have been no collisions and optimize,
//! or to ignore the risk entirely and live dangerously.

mod history;

pub mod join;
pub mod reduce;
Expand Down
Loading
Loading