Repository navigation
docs: publish Proxmox Manager website via GitHub Pages - #47
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a93973e06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| paths: | ||
| - 'site/**' | ||
| - '.github/workflows/deploy-pages.yml' |
There was a problem hiding this comment.
When a push to main changes only README.md or README.de.md, this path filter skips deployment even though site/src/pages/anleitung.astro reads both files at build time. Consequently, corrections to installation instructions, commands, or configuration remain absent from the published guide until an unrelated site change or manual deployment occurs. Include both README files in the workflow's push paths.
Useful? React with 👍 / 👎.
| const render = text => md.render(prepare(text)); | ||
| const sections = [...english.matchAll(/^## (.+)$/gm)].map((match, i, all) => ({title: match[1], id: `ref-${i + 1}`, content: english.slice(match.index, all[i + 1]?.index ?? english.length)})); |
There was a problem hiding this comment.
The embedded English reference contains links such as #-installation, #health-monitoring--alerts, and #relaying-through-an-external-smtp-provider, but MarkdownIt does not generate heading IDs here, and the surrounding sections use unrelated ref-N IDs. Clicking these links in the published guide therefore does not reach the referenced installation, protected-topic, or SMTP instructions. Generate compatible heading IDs, remap the fragments to actual destinations, or redirect these links to the corresponding README anchors on GitHub.
Useful? React with 👍 / 👎.
Adds a static Astro 7 documentation website with self-hosted terminal demo, guide, health and privacy pages. Deploys via GitHub Actions to the project Pages path. Verified on z2: npm ci, npm run build (5 routes), npm audit --omit=dev (0 vulnerabilities), built-artifact privacy and command checks.