Repository navigation
Refactor: Clean up code cosmetics and add HistoryPanel tests - #75
Conversation
…n- Renamed `spin_history_size` to `combo_history_size` in settings\n- Fixed variable shadowing (`signal` -> `sig`) in TTS worker loop\n- Added isolated test suite `test_history_panel.py` covering logic constraints Co-authored-by: TimInTech <129355283+TimInTech@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3777ddd338
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @pytest.fixture | ||
| def history_panel(qapp): |
There was a problem hiding this comment.
In the repository's documented test environment, all five new tests fail at setup because qapp is not available to this module. The existing fixtures with that name are local to other test modules, tests/conftest.py does not provide one, and requirements-dev.txt does not install pytest-qt. Consequently, the full test run in .github/workflows/blitztext-linux-ci.yml fails even when all declared dependencies are installed. Define a local fixture that creates or reuses a QApplication, or move the existing fixture into the shared conftest.
Useful? React with 👍 / 👎.
…sts failing on CI missing `qapp` fixture due to import dependencies\n- Removes implicit `qapp` requirement that broke runner isolation Co-authored-by: TimInTech <129355283+TimInTech@users.noreply.github.com>
Addresses minor linting issues (shadowed variable and misleading variable name) and improves test coverage for the
HistoryPanellogic without requiring full integration tests.PR created automatically by Jules for task 9457665376381873713 started by @TimInTech