Skip to content

fix: grant suite read access to Pi-hole logs - #33

Merged
TimInTech merged 1 commit into
mainfrom
fix/dns-log-permissions
Oct 28, 2026
Merged

TimInTech merged 1 commit into
mainfrom
fix/dns-log-permissions

Conversation

@TimInTech

@TimInTech TimInTech commented Oct 28, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Add the existing Pi-hole log group as a supplementary group for the suite service.
  • Verify the staged upgrade installs this permission override.

Verification

  • Full local test suite and isolated upgrade/rollback checks passed.
  • Production diagnosis showed /dns returned 503 because the service user could not read /var/log/pihole/pihole.log; DNS and both web surfaces remained healthy.

This change only grants read access through Pi-hole's existing group. It does not alter DNS resolver configuration.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T03:49:58.780808Z 8225177 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@TimInTech
TimInTech merged commit 0d78153 into main Oct 28, 2026
6 checks passed
@TimInTech
TimInTech deleted the fix/dns-log-permissions branch October 28, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant