preflight: read systemctl is-enabled on any exit code - #50
Merged
Merged
Conversation
On VTA the brain tile said "is-enabled unknown" because systemctl is-enabled prints "disabled" and exits 1, and _run() dropped the output on non-zero. any_rc=True returns the word for that one call. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
claudemm's review of #50: same defect class in the presence and dash tiles; they said "unknown" for inactive or failed units. any_rc=True on both calls; test names a failed presence unit. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found on VTA right after #48 merged: the brain tile said
is-enabled unknownforcarwatch-brain.systemctl is-enabledprintsdisabledand exits 1;_run()returned None on any non-zero exit, so the answer was discarded._run(..., any_rc=True)returns stdout regardless of the exit code, used for that one call. Tests:disabledwith exit 1 is returned underany_rcand still None without it (against the real_run, not the fixture stub); the brain tile names the disabled unit. Suite 106 OK locally; thetestsworkflow gates the PR.Agent-authored by @claudemb.
🤖 Generated with Claude Code