Repository navigation
Fix stored XSS in bs_tcontent and update Bootstrap to 3.4.1 - #84
Merged
Merged
Conversation
The id attribute was emitted unquoted (id=VALUE). esc_attr() does not encode spaces, so a space in the id ended the attribute and let a Contributor inject arbitrary attributes such as event handlers (stored XSS). Quoting the value closes the hole; rendered output for normal ids is unchanged. Also drops an unused global from bs_dropdown. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bootstrap 3.3.5 is affected by CVE-2018-14040, CVE-2018-14041, CVE-2018-14042 and CVE-2019-8331 (XSS via data-parent, data-target, data-container and data-template). WordPress allows data-* attributes in Contributor post content and the plugin initialises tooltips page-wide, so these were reachable without any shortcode. 3.4.1 is the final Bootstrap 3 release and a drop-in replacement. Files are the unmodified upstream builds (match the published SRI hashes); glyphicon fonts are identical between the two versions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Newer WordPress renamed the TinyMCE "Toolbar Toggle" button to "Extended Toolbar", so the specs never expanded the row holding the plugin's buttons and every editor test failed. Match either label. Also removes leftover debug code that wrote dom-debug*.html files into the repo root on every run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security patch for 3.4.6, plus some backwards-compatible cleanup.
[bs_tcontent]: theidattribute was output unquoted (id=VALUE).esc_attr()does not encode spaces, so a Contributor could inject extra attributes such as event handlers. The value is now quoted; output for normal ids is unchanged. A regression test is included. Reported privately by a security researcher.data-*in Contributor content and the plugin initialises tooltips page-wide, so these were reachable. 3.4.1 is the final Bootstrap 3 release and a drop-in replacement. The files are unmodified upstream builds and the glyphicon fonts are identical.dom-debug*.htmlinto the repo root is removed.readme.txtchangelog entry for 3.4.6.Fixes #68. Supersedes #69.
Release note
Release as 3.4.6 (
npm run release -- 3.4.6). A stray3.4.5tag from an earlier aborted release already exists, and WordPress.org currently serves 3.4.4.Testing
Run locally against WordPress 7.1.3 via wp-env:
🤖 Generated with Claude Code