Skip to content

Button href target - #72

Closed
No3x wants to merge 1 commit into
TheWebShop:masterfrom
No3x:target-new
Closed

No3x wants to merge 1 commit into
TheWebShop:masterfrom
No3x:target-new

Conversation

@No3x

@No3x No3x commented Jun 30, 2016

Copy link
Copy Markdown
Contributor

Added target attribute to buttons as requested in the support forums.

@Sinetheta

Copy link
Copy Markdown
Member

Thank you @No3x, and apologies for the very long wait. As part of a maintenance cleanup we've brought your button target option in via #85. It's adapted to the current code, with an allowlist of target values and rel="noopener noreferrer" for new tabs. If anything comes up, you're always welcome back. Thanks for contributing!

@Sinetheta Sinetheta closed this Oct 18, 2026
Sinetheta pushed a commit that referenced this pull request Oct 24, 2026
Applied from #72, adapted to the current escaped bs_button output:

- target is optional and omitted by default, so existing shortcodes
  render exactly the same HTML as before
- only _blank, _self, _parent and _top are accepted (case-insensitive);
  any other value is dropped
- _blank also adds rel="noopener noreferrer"
- the Buttons popup gets an "Open link in" select defaulting to
  "Same window", which leaves target out of the inserted shortcode;
  the popup is 60px taller to fit it

Also applied from #61: a readme Requirements note explaining when to
uncheck the bundled Bootstrap CSS/JS settings (both original commits
squashed and reworded to name the exact settings).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants