fix(ww3d2): Copy string setter inputs before freeing potentially aliased storage

[CryoTheRenegade]

Fix several string setters that freed the owned buffer before copying the new value, which is unsafe when the input aliases the current storage (e.g. self-assignment / overlapping pointers).
Duplicate first, then free, in AggregateDefClass::Set_Name, ParameterClass::Set_Name, ParticleEmitterClass::Set_Name, and ParticleEmitterDefClass::Set_Name / Set_User_String.

Found by clang-tidy

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: bf964c48-6d79-4d14-ad11-88498152ef7a

📥 Commits

Reviewing files that changed from the base of the PR and between 8605738 and 5b93732.

📒 Files selected for processing (6)

• Core/Libraries/Source/WWVegas/WW3D2/agg_def.h
• Core/Libraries/Source/WWVegas/WWSaveLoad/parameter.h
• Generals/Code/Libraries/Source/WWVegas/WW3D2/part_emt.cpp
• Generals/Code/Libraries/Source/WWVegas/WW3D2/part_ldr.cpp
• GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/part_emt.cpp
• GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/part_ldr.cpp

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

Walkthrough

Changes

String replacement ordering

Layer / File(s)	Summary
Core string setter updates Core/Libraries/Source/WWVegas/WW3D2/agg_def.h, Core/Libraries/Source/WWVegas/WWSaveLoad/parameter.h	Core name setters now duplicate replacement strings before releasing existing allocations.
Particle emitter string setter updates Generals/Code/Libraries/Source/WWVegas/WW3D2/part_emt.cpp, Generals/Code/Libraries/Source/WWVegas/WW3D2/part_ldr.cpp, GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/part_emt.cpp, GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/part_ldr.cpp	Particle emitter name and user-string setters now duplicate replacement strings before releasing existing values. Null replacement behavior remains supported.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 5b937

The string replacement changes preserve aliased inputs without introducing an identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly summarizes the main change: string setters now copy inputs before freeing potentially aliased storage.
Description check	✅ Passed	The description directly explains the affected setters, the aliasing issue, the fix, and the clang-tidy finding.

---

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge and correctly addresses aliased string inputs without changing established setter contracts.

Summary

This PR fixes aliasing-related use-after-free behavior in several WW3D2 string setters by duplicating incoming strings before releasing existing owned storage.

• Updates the shared aggregate and parameter setters.
• Applies equivalent particle-emitter changes to both Generals and Generals Zero Hour.
• Preserves existing null-input behavior and allocator pairing.

_{Reviews (1) · Last reviewed commit: "fix(ww3d2): Copy string setter inputs be..."}

[xezon]

Makes sense.