Skip to content

refactor(particlesys): Use particle alignment enum for batching and clarify helper names - #3309

Open
stephanmeesters wants to merge 3 commits into
TheSuperHackers:mainfrom
stephanmeesters:refactor/batching-enum
Open

refactor(particlesys): Use particle alignment enum for batching and clarify helper names#3309
stephanmeesters wants to merge 3 commits into
TheSuperHackers:mainfrom
stephanmeesters:refactor/batching-enum

Conversation

@stephanmeesters

@stephanmeesters stephanmeesters commented Sep 17, 2026

Copy link
Copy Markdown

Minor refactor to clarify bookkeeping in particle batching.

@coderabbitai

This comment was marked as spam.

Sign in to view
@stephanmeesters stephanmeesters added Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour Refactor Edits the code with insignificant behavior changes, is never user facing labels Sep 17, 2026
@coderabbitai
coderabbitai Bot requested a review from Mauller September 17, 2026 10:36
@greptile-apps

greptile-apps Bot commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness or repository-rule issues.

Summary

This PR clarifies particle-system bookkeeping by exposing particle alignment directly, renaming the field-particle helper, and retaining the complete alignment enum while batching.

  • Replaces billboard boolean bookkeeping with ParticleAlignmentType.
  • Separates batches when their exact particle alignments differ.
  • Fixes the previously unqualified billboard enumerator reference.

Reviews (4) · Last reviewed commit: "Remove shouldBillboard"

stephanmeesters
stephanmeesters commented Sep 17, 2026
View reviewed changes
Comment thread Core/GameEngine/Include/GameClient/ParticleSys.h Outdated
greptile-apps[bot]
greptile-apps Bot reviewed Sep 17, 2026
View reviewed changes
Comment thread Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DParticleSys.cpp Outdated
@stephanmeesters
stephanmeesters force-pushed the refactor/batching-enum branch 2 times, most recently from 236ed24 to b22af4d Compare September 17, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@xezon xezon xezon approved these changes
@Mauller Mauller Awaiting requested review from Mauller

Assignees

No one assigned

Labels

Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing ZH Relates to Zero Hour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stephanmeesters @xezon