Skip to content

ci: Remove ffmpeg label from job title - #3305

Merged
xezon merged 1 commit into
TheSuperHackers:mainfrom
tsunamistate:remove-ffmpeg-label
Sep 17, 2026
Merged

xezon merged 1 commit into
TheSuperHackers:mainfrom
tsunamistate:remove-ffmpeg-label

Conversation

@tsunamistate

Copy link
Copy Markdown

Following discussion in #3251 (comment) it was pointed out that additional features are not needed in job title

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a5ece450-115e-430d-8f8e-4be22c4f9daf

📥 Commits

Reviewing files that changed from the base of the PR and between 039bd17 and 0afcee0.

📒 Files selected for processing (1)
  • .github/workflows/reusable-build-toolchain.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

The reusable build workflow now uses a CMake configure step name without the conditional +ffmpeg suffix. FFmpeg input handling and the RTS_BUILD_OPTION_FFMPEG build flag remain unchanged.

Changes

Build toolchain workflow

Layer / File(s) Summary
Configure step label
.github/workflows/reusable-build-toolchain.yml
The CMake configure step name no longer includes the conditional +ffmpeg suffix. FFmpeg configuration remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: tintinhamans

Merge Risk: ⚪ Minimal · up to 0afce

This PR changes CI display text only and does not alter build behavior, so it is ready to merge.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the +ffmpeg label from the CI job title.
Description check ✅ Passed The description explains why the +ffmpeg label was removed and directly relates to the changeset.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from tintinhamans September 16, 2026 12:21
@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown
Greptile Summary

The PR simplifies the GitHub Actions configure-step label by removing the +ffmpeg suffix.

  • Build configuration and FFmpeg behavior remain unchanged.
  • The label now matches the naming convention used by the job and related build, collection, and upload steps.
Confidence Score: 5/5

The PR appears safe to merge because it changes only a display label and preserves all build behavior.

No actionable failures remain; the removed suffix has no in-repository consumers, and FFmpeg configuration continues to be passed through the existing CMake flag.

Important Files Changed
Filename Overview
.github/workflows/reusable-build-toolchain.yml Removes an unnecessary FFmpeg feature suffix from a display-only workflow step name without changing execution behavior.

Reviews (1): Last reviewed commit: "build(ci): Remove `+ffmpeg` label from j..." | Re-trigger Greptile

@Skyaero42 Skyaero42 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine

@xezon xezon changed the title build(ci): Remove +ffmpeg label from job title ci: Remove ffmpeg label from job title Sep 16, 2026
@xezon xezon added the Build Anything related to building, compiling label Sep 16, 2026
@xezon
xezon merged commit b753898 into TheSuperHackers:main Sep 17, 2026
24 checks passed
gamezerve pushed a commit to gamezerve/Reborn-Omega that referenced this pull request Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Anything related to building, compiling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants