fix(w3dmodeldraw): Prevent null dereference in W3DModelDraw::handleClientRecoil()

[CryoTheRenegade]

Fixes a null-pointer dereference when drawing a model without a current model state. handleClientRecoil() previously read m_curState->m_validStuff even when m_curState was null.

Found by clang-tidy

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: afb9d98f-e0fc-4fd4-9203-5abd3229c4a7

📥 Commits

Reviewing files that changed from the base of the PR and between 4f3482d and b46e669.

📒 Files selected for processing (1)

• Core/GameEngineDevice/Source/W3DDevice/GameClient/Drawable/Draw/W3DModelDraw.cpp

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

Walkthrough

handleClientRecoil now checks that the current model condition state exists before accessing barrel data. Recoil and muzzle flash processing continues only when both state and barrel data are valid.

Changes

Recoil handling safety

Layer / File(s)	Summary
Validate recoil state Core/GameEngineDevice/Source/W3DDevice/GameClient/Drawable/Draw/W3DModelDraw.cpp	handleClientRecoil now requires a non-null current state and valid barrel data before processing recoil and muzzle flashes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to b46e6

The recoil path safely skips processing without a model state, with no remaining merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the null dereference fix in W3DModelDraw::handleClientRecoil().
Description check	✅ Passed	The description explains the null-pointer dereference, the affected function, the cause, and the clang-tidy finding.

---

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Greptile Summary

This PR prevents handleClientRecoil() from dereferencing a null current model state.

• Adds an early return when m_curState is null.
• Preserves the existing barrel-validity check and all behavior for non-null states.

Confidence Score: 5/5

The PR appears safe to merge and directly prevents the reported null-pointer dereference without changing valid-state behavior.

The raw pointer null check short-circuits before member access, while existing behavior is preserved whenever a current state exists; no actionable regressions or rule violations were found.

Important Files Changed

Filename	Overview
Core/GameEngineDevice/Source/W3DDevice/GameClient/Drawable/Draw/W3DModelDraw.cpp	Adds a correctly short-circuited null guard before accessing the current model state's barrel metadata.

_{Reviews (1): Last reviewed commit: "fix(W3DDevice): Return from handleClient..." | Re-trigger Greptile}

[bobtista]

LGTM good find. Maybe add labels to the PR, and did clang-tidy find a bunch more like this? If so, could make another PR with many of the same kind of change

[CryoTheRenegade]

Clang-Tidy found a bunch, but I feel that a lot of them are not 100% accurate so i'm slowly running through a list to see if anything pops out at me before bulk applying fixes that may not be needed.

[xezon]

While at it, also move this past the return.