There are at least 6 places where the xfer code checks against currentVersion instead of version.
- (seems intentional considering the comment)
|
// kill no matter what (old versions default to FALSE). |
|
if( currentVersion >= 2 ) |
|
{ |
|
xfer->xferBool( &m_kill ); |
|
} |
- (also in Zero Hour)
|
if (currentVersion >= 2) |
|
{ |
|
// save the game mode. |
|
Int gameMode = (Int)TheGameLogic->getGameMode(); |
|
xfer->xferInt( &gameMode); |
|
} |
- (also in Zero Hour)
|
if (currentVersion >= 2) |
|
{ |
|
// get the game mode. |
|
Int gameMode; |
|
xfer->xferInt(&gameMode); |
|
TheGameLogic->setGameMode((GameMode)gameMode); |
|
} |
|
if ( currentVersion >= 3 ) |
|
{ |
|
xfer->xferBool( &swInfo->m_evaReadyPlayed ); |
|
} |
|
if ( currentVersion >= 3 ) |
|
{ |
|
xfer->xferBool( &evaReadyPlayed ); |
|
} |
|
else |
|
{ |
|
evaReadyPlayed = ready; |
|
} |
|
if( currentVersion >= 2 ) |
|
{ |
|
xfer->xferSTLObjectIDVector( &m_counterMeasures ); |
|
xfer->xferUnsignedInt( &m_availableCountermeasures ); |
|
xfer->xferUnsignedInt( &m_activeCountermeasures ); |
|
xfer->xferUnsignedInt( &m_divertedMissiles ); |
|
xfer->xferUnsignedInt( &m_incomingMissiles ); |
|
xfer->xferUnsignedInt( &m_reactionFrame ); |
|
xfer->xferUnsignedInt( &m_nextVolleyFrame ); |
|
} |
Used regex queries, may be incomplete:
(?<!const\s+)(XferVersion\s+\w+\s*=\s*\d+)
XferVersion\s+(?!(?:currentVersion|version)\b)
if.*currentVersion
(^\s*)(XferVersion\s+currentVersion) -> $1const $2
There are at least 6 places where the xfer code checks against
currentVersioninstead ofversion.GeneralsGameCode/Core/GameEngine/Source/GameLogic/System/Damage.cpp
Lines 155 to 159 in bfa3bbf
GeneralsGameCode/Generals/Code/GameEngine/Source/Common/System/SaveGame/GameStateMap.cpp
Lines 311 to 316 in bfa3bbf
GeneralsGameCode/Generals/Code/GameEngine/Source/Common/System/SaveGame/GameStateMap.cpp
Lines 342 to 348 in bfa3bbf
GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameClient/InGameUI.cpp
Lines 468 to 471 in bfa3bbf
GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameClient/InGameUI.cpp
Lines 515 to 522 in bfa3bbf
GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Behavior/CountermeasuresBehavior.cpp
Lines 393 to 402 in bfa3bbf
Used regex queries, may be incomplete:
(?<!const\s+)(XferVersion\s+\w+\s*=\s*\d+)XferVersion\s+(?!(?:currentVersion|version)\b)if.*currentVersion(^\s*)(XferVersion\s+currentVersion)->$1const $2