Repository navigation
fix: address post-merge review findings - #31
Merged
Merged
Conversation
added 2 commits
November 1, 2026 19:47
Native registry: lock the temporary directory down before the file exists, abort when the restriction fails, clean up on SIGINT/SIGTERM/SIGHUP, report cleanup failures, and sweep stale registries from hard kills. Dry runs no longer write keys to disk. Legacy mode accepts a provider with only apiKeyCommand and reports it as legacy-only in --list-providers and doctor. The router steps down only when a 400 body mentions the reasoning effort. Doctor sanitizes the version probe environment, reports discovery failures and distinguishes keyed from authless providers. Redact COPILOT_PROVIDER_HEADERS in dry-run output and validate headers as a string map.
Describe the permission, cleanup and stale-sweep guarantees, the legacy-only apiKeyCommand, the effort-400 behavior, and the new verification evidence. Update CHANGELOG and AGENTS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #30, addressing the findings from the delayed review of that PR. The merge landed before the review finished; this branch fixes the valid points on top of
main.Change
--native-byok --dry-runno longer writes provider keys to disk. With no active provider it returns the native shape (mode: native-byok, empty arrays) instead of falling back to the stock dry-run shape.--legacyaccepts a provider that only hasapiKeyCommand(Copilot CLI 1.0.84+).--list-providersanddoctormark it as legacy-only, because the CLI'sproviders.jsonregistry has no credential-command equivalent.400body mentions the reasoning effort. Ordinary context, schema or content-policy400s are forwarded unchanged instead of consuming seven retries and polluting the rejection memory.doctorsanitizes the environment of the Copilot version probe, reports discovery failures in--onlineinstead of an empty success, and distinguishes keyed providers, authless providers and credential-command providers.COPILOT_PROVIDER_HEADERSis redacted in dry-run output, andheadersmust be an object of strings likemodelsHeaders.models, headers validation.Verification
npm run check: lint clean; 235 tests, 233 pass, 2 skipped (POSIX-only), 0 fail.npm pack --dry-run: 43 files, 79.3 kB.npm audit --omit=dev --audit-level=high: 0 vulnerabilities.Checklist
npm run checkpassesnpm pack --dry-runpassesnpm audit --omit=dev --audit-level=highpassesdocs/fileCHANGELOG.mdupdated when user-visible behavior changed