Repository navigation
add Vehicle faker with comprehensive vehicle data generation - #35
Merged
Merged
Conversation
Implements Vehicle faker per spec: make, model, makeAndModel, color, fuelType, transmission, driveType, vehicleType, doors, carOption, standardSpec, vin, licensePlate, year, mileage, engine. Adds models, vehicle_types, and license_plate_patterns to vehicle.yml. Updates LEARNINGS.md with two new lessons (YAML integer quoting, bothify uppercase flag). Fixes yaml-check to prefer yq over python3.
Pull Request Test Coverage Report for Build 22526141304Details
💛 - Coveralls |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vehiclefaker class with 15 methods:make,model,makeAndModel,color,fuelType,transmission,driveType,vehicleType,doors,carOption,standardSpec,vin,licensePlate,year,mileage,enginevehicle.ymlwithmodels(flat list),vehicle_types, andlicense_plate_patterns; fixesdoorsvalues to be quoted strings (integers causedClassCastExceptioninfetchString())VehicleinFaker.java(field, constructor init, getter)LEARNINGS.mdentries for YAML integer quoting andbothify(pattern, true)for uppercase outputyaml-checkinjustfileto preferyqoverpython3(PyYAML was not installed, breaking the pre-commit hook)Test plan
./mvnw test -Dtest=VehicleTest— all 18 tests pass./mvnw test— full suite (85,215 tests) passes with no regressionsformat-check,compile,yaml-validate