(fix and update) github actions implementation and also deployment sc… - #23
Merged
Merged
Conversation
All six checks failed on push. None of it reproduced locally, because every failure came from state a working copy has and a fresh CI checkout does not. 1. prisma.config.ts resolved DATABASE_URL through prisma's env() helper, which throws while the config is being LOADED if the variable is missing. .env is gitignored, so `prisma generate` — an offline codegen step that never connects — died on PrismaConfigEnvError. That killed the quality and build jobs, and the deploy verify job with them. Read via process.env instead; commands that truly need a database still fail at connect time, which is the right place for it. 2. turbo's check-types depended on ^check-types, which typechecks a dependency without emitting its dist/. Packages resolve each other's types through dist/, so on a checkout with no prior build, @repo/game could not find @repo/protocol. Depend on ^build instead. 3. The test job ran tsc with no dependency build at all; same missing module, so build @repo/game's deps first. 4. DIFFICULTY_WEIGHT.HARD is possibly-undefined under noUncheckedIndexedAccess — a real error that local turbo cache was replaying a stale pass for. 5. pnpm 10 was silently skipping install scripts for prisma, @prisma/engines, esbuild, sharp and msgpackr-extract, so their binaries were never fetched. Allow them via only-built-dependencies. Verified by running all three jobs against a clean `git archive` export with no .env, no node_modules and no dist: quality 13/13, tests 156/156, build 9/9. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ript ready