Skip to content

BakedQuadVertexBuilder bug fix and shading option #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
covers1624 merged 2 commits into from
Oct 6, 2026
Merged

BakedQuadVertexBuilder bug fix and shading option #476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c6e6e8
Fix ARGB order in BakedQuadVertexBuilder
MrTJP Oct 4, 2026
f5c4d8d
Add shade/ao options in BakedQuadVertexBuilder
MrTJP Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/main/java/codechicken/lib/render/buffer/BakedQuadVertexBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ public class BakedQuadVertexBuilder implements VertexConsumer, ISpriteAwareVerte
private final List<BakedQuad> quadList = new ArrayList<>();
private final VertexFormat.Mode mode;

private boolean shade = false;
private boolean ambientOcclusion = true;

private final Quad current = new Quad();
private int vertex = -1;

Expand All @@ -38,9 +41,15 @@ public BakedQuadVertexBuilder(VertexFormat.Mode mode) {

public void reset() {
quadList.clear();
shade = false;
ambientOcclusion = true;
vertex = -1;
}

public void setShade(boolean shade) {
this.shade = shade;
}

@Override
public void sprite(TextureAtlasSprite sprite) {
current.sprite = sprite;
Expand All @@ -61,7 +70,7 @@ public VertexConsumer setColor(int color) {

@Override
public VertexConsumer setColor(int red, int green, int blue, int alpha) {
setColor(ARGB.color(red, green, blue, alpha));
setColor(ARGB.color(alpha, red, green, blue));
return this;
}

Expand Down Expand Up @@ -106,6 +115,8 @@ private void endPrevVertex() {
throw new IllegalStateException("Sprite not set.");
}
current.calculateOrientation(false);
current.shade = shade;
current.ambientOcclusion = ambientOcclusion;
quadList.add(current.bake());
vertex = 0;
}
Expand Down
Loading