Device Settings: collapse advanced settings under an Advanced section - #402
Merged
Merged
Conversation
The garage's Device Settings tab listed every logger setting flat, so detection thresholds and debug toggles sat between the name and display fields a normal user actually touches. Settings flagged `advanced` in the schema (lap/waypoint detection distances, waypoint speed, debug pages, legacy CSV) now render inside a collapsed "Advanced" collapsible; the default is normal, so a new setting — or an unknown key from a newer firmware — stays visible in the main list unless deliberately flagged. Row edit/save handlers moved from index-based to key-based so the list can be partitioned without the indices drifting. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tf5HFjmeFZKkzh4nxcE8bV
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Coverage SummaryLines: 58.66% (7602/12958) · Statements: 57.8% · Functions: 55.86% · Branches: 55.69% Per-file coverage
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lapwing | 3a71867 | Commit Preview URL Branch Preview URL |
Aug 12 2026, 02:49 AM |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tf5HFjmeFZKkzh4nxcE8bV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UI-only cleanup of the garage's Device Settings tab. The flat settings list mixed everyday fields (names, display colours, RPM setup) with expert knobs, so the schema now carries an
advanced?: booleanflag and the tab renders flagged settings inside a collapsed Advanced collapsible (house style, matchingPostSessionPanel), below the main list and above the reset button.lap_detection_distance,waypoint_detection_distance,waypoint_speed,debug_pages,use_legacy_csv.isAdvancedSetting()is the single pure gate, with Vitest coverage.device.advancedi18n key added across all 7 locales.Related Issues
None.
Type of Change
Checklist
npm run lintpassesnpm run typecheckpassesnpm run test:runpasses (2850 tests)npm run buildsucceedsCHANGELOG.md— new[4.1.0] - unreleasedblock)datalogParser.ts, added tests, updated the formats table (n/a)Notes for Reviewers
[4.1.0] - unreleasedheading — shout if the next version should be a patch instead.Generated by Claude Code