Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
mat_bin_search(3, [[1, 2], [3, 4]])currently returns[-1, -1]instead of[1, 0]. After the first row is searched, the loop conditionmatrix[index][0] < valuestops when the target equals the first element of the next row, so that row is never searched. Using<=includes that boundary row.A previous proposal for the same one-line correction, PR #15548, was closed by
algorithms-keeperbecause that author already had multiple open PRs. It did not merge, and the upstream source still has the bug.Verification
mat_bin_search(3, [[1, 2], [3, 4]]) -> [1, 0].<condition stops at row 1 before the binary search call; the updated<=condition reaches that call.Checklist
I have read CONTRIBUTING.md.
I know that pull requests will not be merged if they fail the automated tests.
This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
All new Python files are placed inside an existing directory. (No new files.)
All filenames are in lowercase and use underscores. (No new files.)
All function parameters and return values are annotated. (No signature changes.)
All new algorithms include a reference URL. (No new algorithm.)
If this pull request resolves an issue, include its closing keyword. (No linked issue.)