Skip to content

fix: NameError when importing matrix_exponentiation.py - #15078

Open
Georgefifth wants to merge 1 commit into
TheAlgorithms:masterfrom
Georgefifth:fix/matrix-exponentiation-nameerror
Open

fix: NameError when importing matrix_exponentiation.py#15078
Georgefifth wants to merge 1 commit into
TheAlgorithms:masterfrom
Georgefifth:fix/matrix-exponentiation-nameerror

Conversation

@Georgefifth

Copy link
Copy Markdown

Describe your change:

maths/matrix_exponentiation.py raises NameError: name 'Matrix' is not defined on import: Matrix.__mul__ uses Matrix in its own annotation, which is evaluated while the class body is still executing (introduced by the type hints in #14288). The fix adds from __future__ import annotations to defer annotation evaluation, matching the convention already used in 250+ files in this repo (e.g. maths/prime_factors.py). Two-line diff, no behavior change.

Verified: before the fix the import fails with the reported NameError; after the fix the import succeeds and python3 -m doctest maths/matrix_exponentiation.py passes (10/10). I also scanned all of maths/ for the same pattern and this is the only occurrence.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Fixes #15075

Matrix.__mul__ references the Matrix class in its own annotation, which
is evaluated while the class is still being defined. This makes importing
the module raise NameError. Adding 'from __future__ import annotations'
defers annotation evaluation, matching the convention used elsewhere in
the repository.

Closes TheAlgorithms#15075
@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] NameError on self-referential class type annotations in matrix_exponentiation.py

1 participant