Skip to content

fix: NameError when importing matrix_exponentiation.py - #15077

Closed
Georgefifth wants to merge 1 commit into
TheAlgorithms:masterfrom
Georgefifth:fix/matrix-exponentiation-nameerror
Closed

fix: NameError when importing matrix_exponentiation.py#15077
Georgefifth wants to merge 1 commit into
TheAlgorithms:masterfrom
Georgefifth:fix/matrix-exponentiation-nameerror

Conversation

@Georgefifth

Copy link
Copy Markdown

Problem

Importing maths/matrix_exponentiation.py raises NameError: name 'Matrix' is not defined. Matrix.__mul__ uses Matrix in its own annotation, which is evaluated while the class body is still executing, before the name exists. The type hints were added in #14288.

Solution

Add from __future__ import annotations to defer annotation evaluation. This is the same fix already used in 250+ files in this repo (e.g. maths/prime_factors.py). Two-line diff, no behavior change.

Verification

  • Before: python3 -c 'import maths.matrix_exponentiation' fails with the reported NameError.
  • After: import succeeds and python3 -m doctest maths/matrix_exponentiation.py passes (10/10).
  • ruff check passes.

Also scanned all of maths/ for the same pattern (self-referential annotations without the future import); this is the only occurrence.

Closes #15075

Matrix.__mul__ references the Matrix class in its own annotation, which
is evaluated while the class is still being defined. This makes importing
the module raise NameError. Adding 'from __future__ import annotations'
defers annotation evaluation, matching the convention used elsewhere in
the repository.

Closes TheAlgorithms#15075
@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@Georgefifth, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed invalid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] NameError on self-referential class type annotations in matrix_exponentiation.py

1 participant