fix: NameError when importing matrix_exponentiation.py - #15077
Closed
Georgefifth wants to merge 1 commit into
Closed
fix: NameError when importing matrix_exponentiation.py#15077Georgefifth wants to merge 1 commit into
Georgefifth wants to merge 1 commit into
Conversation
Matrix.__mul__ references the Matrix class in its own annotation, which is evaluated while the class is still being defined. This makes importing the module raise NameError. Adding 'from __future__ import annotations' defers annotation evaluation, matching the convention used elsewhere in the repository. Closes TheAlgorithms#15075
Closing this pull request as invalid@Georgefifth, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines. If you're facing any problem on how to mark a checkbox, please read the following instructions:
NOTE: Only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Importing
maths/matrix_exponentiation.pyraisesNameError: name 'Matrix' is not defined.Matrix.__mul__usesMatrixin its own annotation, which is evaluated while the class body is still executing, before the name exists. The type hints were added in #14288.Solution
Add
from __future__ import annotationsto defer annotation evaluation. This is the same fix already used in 250+ files in this repo (e.g.maths/prime_factors.py). Two-line diff, no behavior change.Verification
python3 -c 'import maths.matrix_exponentiation'fails with the reported NameError.python3 -m doctest maths/matrix_exponentiation.pypasses (10/10).ruff checkpasses.Also scanned all of
maths/for the same pattern (self-referential annotations without the future import); this is the only occurrence.Closes #15075