Fix matrix exponentiation type annotations - #15076
Open
Kanika0306 wants to merge 3 commits into
Open
Conversation
…ons in matrix_exponentiation.py
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes a
NameErrorinPython/maths/matrix_exponentiation.pycaused by self-referential type annotations in theMatrixclass.The
Matrix.__mul__method referencesMatrixin its parameter and return type annotations before the class definition has been fully evaluated. This causes Python to raiseNameError: name 'Matrix' is not definedwhen the module is imported.This change adds
from __future__ import annotationsto postpone the evaluation of type annotations, allowing the self-referentialMatrixannotations to be resolved correctly without changing the algorithm's behavior.Fixes #15075
Checklist: