Skip to content

Add is_palindrome_ignore_case_and_spaces to strings/palindrome.py#14907

Open
kaviya-ns wants to merge 1 commit into
TheAlgorithms:masterfrom
kaviya-ns:add-palindrome-ignore-case-and-spaces
Open

Add is_palindrome_ignore_case_and_spaces to strings/palindrome.py#14907
kaviya-ns wants to merge 1 commit into
TheAlgorithms:masterfrom
kaviya-ns:add-palindrome-ignore-case-and-spaces

Conversation

@kaviya-ns

Copy link
Copy Markdown

Describe your change:

Adds a new function is_palindrome_ignore_case_and_spaces to strings/palindrome.py
that checks whether a string is a palindrome while ignoring letter case and spaces.
Existing functions in the file are unchanged.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword.

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jul 7, 2026

@Abhirai2006 Abhirai2006 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice small addition, thanks! Two things I noticed though:

The doctest with "Was it a car or a cat I saw?" returns False, but that's kind of an accident — it's only False because the trailing "?" doesn't get stripped (the function only removes spaces, not punctuation). If you actually remove the "?", that phrase is a real palindrome ignoring case/spaces. So the test passes but not really for the reason you'd want it to. Might be worth swapping in a cleaner example, or handling punctuation too so the function does what its name says.

Also the new assert in main (is_palindrome(key) == is_palindrome_ignore_case_and_spaces(key)) is checked against the existing test_data, but none of those strings have spaces or mixed case — so it's not really testing the new behavior, just repeating the old check. Adding one or two mixed-case/spaced entries would make that assertion actually mean something.

Otherwise looks good, happy to approve once these are sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants