Fix cloud SessionStart hook interpreter; theme-aware Plotly axis lines - #128
Merged
Merged
Conversation
The hook upgraded setuptools with `python -m pip` but installed the package with bare `pip`. In the cloud image `pip` is /usr/bin/pip (distro Python) while `python` is /usr/local/bin/python, so the install ran against the distro setuptools, failed to build pyscf-properties, and (under set -e) left the session with nothing installed. This is the "pyscf-properties uninstallable in cloud" watchlist item; it was never environmental. Verified: with pyscf-properties uninstalled, the fixed hook reinstalls it and exits 0, and the full `pytest -m "not network"` suite passes in the cloud container (previously 23 NMR/Raman failures). Contributions: - Claude (Opus 5.5): code edits, review, and conceptual discussion - Jonathan Schultz: overall vision, planning, review, and orchestration Co-authored-by: Jonathan Schultz <nccu-schultz-lab@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
_apply_plotly_theme() set background, font and grid colors but not linecolor/zerolinecolor, which stayed at the plotly_white template's pale blue-gray default, meant for white backgrounds. Both now use the palette's border_strong (new plotly_colors()["axis_line_color"]), one step stronger than the grid, so axes stay visible and consistent on dark palettes. M-THEME's remaining "hex tail" item. Still needs a Voila visual pass on a dark palette. Contributions: - Claude (Opus 5.5): code edits, review, and conceptual discussion - Jonathan Schultz: overall vision, planning, review, and orchestration Co-authored-by: Jonathan Schultz <nccu-schultz-lab@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small fixes ahead of the 0.9.0 bump.
pipvspythoninterpreter mismatch (.claude/hooks/session-start.sh)python -m pip, then installed the package with barepip.pipis/usr/bin/pip(the distro Python) whilepythonis/usr/local/bin/python, so the install used the distro's setuptools.pyscf-properties, and because the hook runs withset -e, the session ended up with nothing installed.pyscf-propertiesuninstallable in cloud" watchlist item, which was previously treated as an environment limitation.python -m pip install -e ".[pyscf,ase,dev,xtb]".quantui/app.py,quantui/theme.py)_apply_plotly_theme()set background, font and grid colors, but leftlinecolor/zerolinecolorat theplotly_whitetemplate's pale default.border_strong, exposed as the newplotly_colors()["axis_line_color"]. That is one step stronger than the grid color, so axes stay visible on dark palettes.Testing
pyscf-properties, then ran the fixed hook withCLAUDE_CODE_REMOTE=true. It reinstalled the package (Successfully installed pyscf-properties-0.1.0) and exited 0.pytest -m "not network"in the cloud container: 3432 passed, 0 failed, 11 skipped. The 23 NMR/Raman failures noted in SLURM job folders with per-attempt subfolders; SLURM results marked in History #127 are gone.test_plotly_colours_track_palettenow also assertsaxis_line_colorfor every palette.pre-commit run(ruff + black) is clean.Authorship
🤖 Generated with Claude Code
Generated by Claude Code