utils.mk: give write_rc a do- sibling - #4545
Merged
Merged
Conversation
flow/Makefile states the convention where it generates the copy rules: "a do- sibling rule that copies the file unconditionally". do-klayout, do-synth-report, do-step and do-copy all follow it. The file target decides whether to run and delegates with $(UNSET_AND_MAKE), and the do- target is the single place the invocation lives. write_rc is the one that conflates the two, so a caller doing its own dependency checking cannot ask for just the operation. The file target delegates rather than keeping a second copy of the $(RUN_CMD) line, which is the same shape as every other do- pair. Make's dependency checking is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the write_rc pattern rule in flow/util/utils.mk to delegate its execution to a new .PHONY target do-write_rc using $(UNSET_AND_MAKE). This aligns it with other do- sibling targets in the build system. There are no review comments, so no additional feedback is provided.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 1 without a comparable baseline. |
maliberty
approved these changes
Sep 22, 2026
maliberty
merged commit Sep 22, 2026
23843c5
into
The-OpenROAD-Project:master
10 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flow/Makefilestates the convention where it generates the copy rules:do-klayout_tech,do-synth-report,do-stepanddo-copyall followit. The file target decides whether to run and delegates with
$(UNSET_AND_MAKE), and thedo-target is the single place theinvocation lives:
write_rcis the one that conflates the two, so a caller doing its owndependency checking cannot ask for just the operation.
The file target delegates rather than keeping a second copy of the
$(RUN_CMD)line, which is the same shape as every otherdo-pair.Make's dependency checking is left exactly as it is.
🤖 Generated with Claude Code