Repository navigation
fix(importer): import list, bounded, enumerated and table properties - #324
Merged
agviegas merged 1 commit intoOct 11, 2026
Merged
Conversation
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323.
Adds
IFCPROPERTYLISTVALUE,IFCPROPERTYBOUNDEDVALUE,IFCPROPERTYENUMERATEDVALUE,IFCPROPERTYENUMERATIONandIFCPROPERTYTABLEVALUEtoifcClasses.properties, so these properties are imported with their names and values instead of being left as empty items that their property set still references. Their values are written by the existing attribute serialization (lists as arrays, bounds as separate attributes).Test
New fixture
resources/ifc/property-values.ifc(one wall, one property set with a list, a bounded, an enumerated and a table property) andsrc/Importers/IfcImporter/src/properties/multi-value-properties.test.ts, which converts it and checks each property's category and values (ListValues, the three bounds,EnumerationValuesof the property and of its enumeration,DefiningValues/DefinedValues).vitest --run144 of 144 pass,tsc -p tsconfig-build.json --noEmitclean.Together with ThatOpen/engine_components#828, buildingSMART's IDS test cases for list and enumerated properties pass.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).