Repository navigation
Conversation
This was referenced Oct 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #821.
IDSProperty.testnow evaluates the facet itself as if it were required (property set, name, value and data type), in a new privateevalFacet. It then applies the cardinality once:BaseNamecheck that passes when the facet does not matchBaseNamecheck, whatever the outcome (IDS developer guide: an optional requirement that would fail if required must not be logged as an error; test casesproperty/pass-an_optional_facet_always_passes_regardless_of_outcome_*)IDSFacet.evalRequirementgains an optionalcardinalityargument, defaulting to the facet's own, soevalFacetcan match names, values and data types without the cardinality being applied to each one.Additional context
facets/property-cardinality.test.tsontests/fixtures/type-psets.ifc: required with a value; prohibited without a value (only the wall without the property passes); optional (all pass, including the wall with noPset_WallCommon). The prohibited and optional cases fail without the change. The existingproperty.test.tsstill passes.vitest --runinpackages/core: all pass.tsc -p tsconfig-build.json --noEmitis clean.evalRequirementper check. They may have similar issues, but I haven't checked them.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).