Repository navigation
fix(ids): decode XML entities on load and escape values on export - #818
Merged
Merged
Conversation
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #817.
processEntities: trueinIDSSpecifications.xmlParser, so&,<,>,"and'are decoded. fast-xml-parser 5.7.2 keeps its default limits on entity expansion.XML.escapehelper inutils/xml.ts, used wherever the IDS export interpolates text: the info block, the specification's name, identifier, description and instructions, each facet's instructions, and simple, enumeration and pattern values.Additional context
load-entities.test.ts: loading decodes entities in a specification name, a property set name and a value; and a load →export()→ load round trip keepsR&D wallsandSmith & Sons <Ltd>. The first test fails without the parser change, and the round trip fails with the parser change but without the escaping.vitest --runinpackages/core: all pass.tsc -p tsconfig-build.json --noEmitis clean.<xs:minInclusive value="…">without closing the element, which is invalid XML on its own. I can open a separate issue for it.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).