Repository navigation
Conversation
This was referenced Oct 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #813.
IDSSpecification.test()now gives each applicability facet its own collector and intersects the results with the existingModelIdMapUtils.intersect. So an element is applicable only when it matches every applicability facet, as IDS defines it. Before, all facets wrote into one shared map, so the result was their union.Additional context
specification.test.tsuses the existingtests/fixtures/type-psets.ifcand the same headless setup asfacets/property.test.ts. "Walls that are external" now tests walls 40, 41, 42 and 46. Without the change it tests all six (expected [40, 41, 42, 43, 45, 46] to deeply equal [40, 41, 42, 46]). A single facet still selects what it did.vitest --runinpackages/core: 59 of 59 pass.tsc -p tsconfig-build.json --noEmitis clean.getEntitiesselects nothing now makes the whole applicability select nothing. That matters for the Attribute facet, whosegetEntitiesis currently empty, and for Classification and PartOf, which are stubs. Under the union those facets were silently ignored; with the intersection, a specification that uses them tests no elements until they are implemented. Both are wrong today in different ways. I can open separate issues for those facets if that helps.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).