docs(router-store): review provide_router_store.ts, no findings - #177
Merged
Conversation
Reviewed provideRouterStore()'s provider wiring - no bug in the file itself, but tracing config.serializer's type flow surfaced a real gap in router_store_config.ts, tracked as this module's next file.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #176.
Summary
modules/router-store/src/provide_router_store.tsfor the per-module code review audit (Code review: @ngrx/router-store #38, sub-issue of Code review: audit all 13 modules #32).provideRouterStore<T>()'s provider wiring is correct and its default/order sensitivities were checked against this audit's known bug classes.config.serializer's type flow surfaced a real gap inrouter_store_config.ts(not parameterized byT), which is filed as this module's next sub-issue rather than fixed here.Test plan
yarn nx run router-store:build-package- cleanyarn nx run router-store:test- 156/156 passing, 1 pre-existing skip, 0 type errors