fix(router-store): add null to selectFragment's return type - #161
Merged
Conversation
RouterStateSelectors.selectFragment was typed MemoizedSelector<V, string | undefined>, missing null - Angular's real ActivatedRouteSnapshot.fragment is string | null, confirmed against @angular/router's own .d.ts. Silently unenforced because the selector chain is any-typed by design (the router state's true shape depends on the consumer's chosen serializer). selectTitle checked for the same class of gap and confirmed correct as-is (a getter Angular itself normalizes to string | undefined). Fix scoped to the one concretely-verified mismatch, not the broader any-typed chain, which is architectural, not a bug. Verified: yarn nx build-package router-store (clean), yarn nx test router-store (156/156, 1 pre-existing skip, 0 type errors), yarn nx lint router-store (0 errors, 1 pre-existing unrelated warning). Closes #160
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviews
modules/router-store/src/models.tsas part of therouter-storemodule code-review audit (#38, sub-issue of #32). Third real finding in this module (all fixed).RouterStateSelectors.selectFragmentwas missingnullfrom its return type, confirmed against Angular's real.d.tsforActivatedRouteSnapshot.fragment. Scoped fix - the broaderany-typed selector chain is intentional architecture, not a bug. Full write-up in the linked issue.Closes #160