fix(router-store): re-export RouterStateSelectors from index.ts - #159
Merged
Conversation
models.ts's RouterStateSelectors<V> - the direct return-type of the already-public getRouterSelectors<V>() - had no way to reach a consumer through the package's normal entry point. Cross-checked every other file's exports against index.ts; everything else matched exactly, including a correct exclusion (StoreRouterConnectingService is genuinely internal wiring, confirmed by the module's own tests importing it from the concrete path rather than the barrel). Verified: yarn nx build-package router-store (clean), yarn nx test router-store (156/156, 1 pre-existing skip, 0 type errors), yarn nx lint router-store (0 errors, 1 pre-existing unrelated warning). Closes #158
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviews
modules/router-store/src/index.tsas part of therouter-storemodule code-review audit (#38, sub-issue of #32). Second real finding in this module (both real, both fixed).RouterStateSelectors<V>- the return type of the already-publicgetRouterSelectors()- was missing from the public barrel, with no way for a consumer to reach it through the package's normal entry point. Every other file's exports were cross-checked and matched exactly. Full write-up and verification steps in the linked issue.Closes #158