Reject non-array data on create_bulk_envs() - #200
Merged
Conversation
\$bulk_data = \$request->get('data') only checked truthiness before
foreach-ing over it. A string value for 'data' passed the truthiness
check, then hit foreach() on a non-iterable, throwing a 500 instead
of the intended 400 validation response.
…s-array-validation
…s-array-validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found via a fresh
/code-reviewpass onapp/Http/Controllers/Api/ServicesController.php(issue #70).create_bulk_envs()only checked truthiness of the request'sdatafield beforeforeach-ing over it (if (! $bulk_data) { ... }). A non-empty string value fordatapasses the truthiness check but isn't iterable, soforeach ($bulk_data as $item)throws a 500 instead of returning a clean validation error.Fix
Check
is_array($bulk_data)(and non-empty) instead of just truthiness.Verification
TDD-proved:
rejects bulk env creation when data is not an arrayfails against the pre-fix code (uncaughtforeach() argument must be of type array|object, string given) and passes after the fix. All 14 tests inServicesEnvsTest.phppass. Pint/PHPStan clean on the changed file.