Restore home marker certification coverage - #50
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughHarness adapters now declare and detect home-directory markers separately from project markers. Local and fake environments support home-path checks. Integration tests verify marker origins and paths. Certification now expects six skipped harnesses. ChangesHome marker detection
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The PR restores home-marker certification behavior and updates related validation without any actionable merge-blocking risk remaining after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant HarnessScanner
participant HarnessEnvironment
participant IntegrationReport
HarnessScanner->>HarnessEnvironment: Check configured home marker
HarnessEnvironment-->>HarnessScanner: Return marker existence
HarnessScanner->>IntegrationReport: Add matching marker with Home origin
IntegrationReport-->>HarnessScanner: Expose relative marker path
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Clippy (1.97.1)Clippy execution failed Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Validation
cargo test --workspace --lockedcargo clippy --locked --all-targetscargo fmt --all -- --checkpython3 scripts/validate-plugin-packages.pysh scripts/certify-tree-ring.shHigh-level PR Summary
This PR restores user-home marker detection in the harness registry while maintaining privacy by keeping marker paths relative. It adds support for detecting harness configuration files in both project and home directories, updates the certification script to bind to the fixture memory root and enforce receipt-gated evidence requirements, and makes scan tests independent of locally installed harnesses by checking for explicit project markers rather than relying on global detection counts.
⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
crates/tree-ring-memory-cli/src/activation/adapters.rscrates/tree-ring-memory-cli/src/main.rscrates/tree-ring-memory-cli/src/tui/app.rsscripts/certify-tree-ring.shSummary by CodeRabbit
New Features
Tests