Skip to content

Restore home marker certification coverage - #50

Merged
TerminallyLazy merged 1 commit into
mainfrom
codex/restore-home-marker-scan
Aug 24, 2026
Merged

Restore home marker certification coverage#50
TerminallyLazy merged 1 commit into
mainfrom
codex/restore-home-marker-scan

Conversation

@TerminallyLazy

@TerminallyLazy TerminallyLazy commented Aug 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • restore read-only user-home marker detection in the versioned harness registry
  • keep marker paths relative so home directories are not exposed
  • make scan tests independent of locally installed harnesses
  • update the certification script for receipt-gated harness evidence and bind it to the fixture memory root

Validation

  • cargo test --workspace --locked
  • cargo clippy --locked --all-targets
  • cargo fmt --all -- --check
  • python3 scripts/validate-plugin-packages.py
  • sh scripts/certify-tree-ring.sh

High-level PR Summary

This PR restores user-home marker detection in the harness registry while maintaining privacy by keeping marker paths relative. It adds support for detecting harness configuration files in both project and home directories, updates the certification script to bind to the fixture memory root and enforce receipt-gated evidence requirements, and makes scan tests independent of locally installed harnesses by checking for explicit project markers rather than relying on global detection counts.

⏱️ Estimated Review Time: 5-15 minutes

💡 Review Order Suggestion
Order File Path
1 crates/tree-ring-memory-cli/src/activation/adapters.rs
2 crates/tree-ring-memory-cli/src/main.rs
3 crates/tree-ring-memory-cli/src/tui/app.rs
4 scripts/certify-tree-ring.sh

Need help? Join our Discord

Summary by CodeRabbit

  • New Features

    • Harness detection now checks home-directory markers in addition to project markers.
    • Detection results distinguish whether markers come from the project or home directory.
    • Added support for relative marker paths and configurable home locations in test environments.
  • Tests

    • Updated integration scans to support multiple detected integrations and verify marker origins and paths.
    • Certification checks now validate expected skipped harnesses when fresh-session receipts are unavailable.

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a31ee0ce-2823-4c38-a2c0-c0c7cb3a7eac

📥 Commits

Reviewing files that changed from the base of the PR and between 73cd2dc and c211a59.

📒 Files selected for processing (4)
  • crates/tree-ring-memory-cli/src/activation/adapters.rs
  • crates/tree-ring-memory-cli/src/main.rs
  • crates/tree-ring-memory-cli/src/tui/app.rs
  • scripts/certify-tree-ring.sh

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Harness adapters now declare and detect home-directory markers separately from project markers. Local and fake environments support home-path checks. Integration tests verify marker origins and paths. Certification now expects six skipped harnesses.

Changes

Home marker detection

Layer / File(s) Summary
Adapter configuration and marker detection
crates/tree-ring-memory-cli/src/activation/adapters.rs
Harness environments support home-path checks. Adapters declare home markers. Detection reports matching markers with MarkerOrigin::Home and relative paths.
Integration scan validation
crates/tree-ring-memory-cli/src/main.rs, crates/tree-ring-memory-cli/src/tui/app.rs
Scan tests allow multiple detections and verify the Codex project marker at .codex.
Harness certification expectations
scripts/certify-tree-ring.sh
Certification uses the scan root’s .tree-ring directory and requires six skips with zero passes and failures.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to c211a

The PR restores home-marker certification behavior and updates related validation without any actionable merge-blocking risk remaining after normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant HarnessScanner
  participant HarnessEnvironment
  participant IntegrationReport
  HarnessScanner->>HarnessEnvironment: Check configured home marker
  HarnessEnvironment-->>HarnessScanner: Return marker existence
  HarnessScanner->>IntegrationReport: Add matching marker with Home origin
  IntegrationReport-->>HarnessScanner: Expose relative marker path
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: restoring certification coverage for home marker detection.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/restore-home-marker-scan

Warning

Some tools did not complete. Review the errors below.

🔧 Clippy (1.97.1)

Clippy execution failed


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TerminallyLazy
TerminallyLazy merged commit 2760abf into main Aug 24, 2026
2 of 3 checks passed
@TerminallyLazy
TerminallyLazy deleted the codex/restore-home-marker-scan branch August 24, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant