Skip to content

⚡ Bolt: Pre-calculate capacity and avoid write! formatting in fstring_concat - #362

Closed
Tcode-Motion wants to merge 2 commits into
mainfrom
perf/fstring-concat-capacity-10688590165131012732
Closed

Tcode-Motion wants to merge 2 commits into
mainfrom
perf/fstring-concat-capacity-10688590165131012732

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

💡 What: Optimized fstring_concat in techscript_builtins by pre-allocating String capacity based on argument types and appending Value::Str using push_str instead of going through write! formatting macro.

🎯 Why: Previously, fstring_concat started with an unallocated String::new() and repeatedly formatted arguments using write!(res, "{}", arg), causing multiple buffer allocations/reallocations and formatting overhead for strings.

📊 Impact: Reduces string allocations and formatting overhead during f-string evaluations in TechScript programs.

🔬 Measurement: Measured with bench_fstring_concat in builtins_tests.rs across 100,000 f-string concatenation operations (reduced execution time from ~199.19ms to ~162.84ms, an ~18% improvement in debug build testing).


PR created automatically by Jules for task 10688590165131012732 started by @Tcode-Motion

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
github-actions Bot marked this pull request as ready for review October 27, 2026 19:33
Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant