Repository navigation
⚡ Bolt: eliminate string cloning in sys_write_file and sys_read_file - #356
Tcode-Motion wants to merge 1 commit into
Conversation
…_file Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
into_string(self)method toRuntimeValueto extract owned strings without cloning, and updatedsys_write_file,sys_read_file, andsys_existsinstdlib/src/sys.rsto consume ownedargswithinto_string().sys_write_filepreviously calledtry_into_string(&self)on arguments, which cloned both file path and content strings. For large files, string cloning incurred redundant heap allocation and memory copying overhead.RuntimeValue::Strarguments in file system standard library functions.sys_write_filecalls.PR created automatically by Jules for task 5554682109399935467 started by @Tcode-Motion